Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22293 )
Change subject: IMPALA-13627: Handle legacy Hive timezone conversion ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22293/3/be/src/exec/parquet/parquet-common.h File be/src/exec/parquet/parquet-common.h: http://gerrit.cloudera.org:8080/#/c/22293/3/be/src/exec/parquet/parquet-common.h@815 PS3, Line 815: /// If timestamp t >= v before conversion, then this function converts v in such a : /// way that the same will be true after t is converted. : void ConvertMinStatToLocalTime(TimestampValue* v) const; : : /// If timestamp t <= v before conversion, then this function converts v in such a : /// way that the same will be true after t is converted. : void ConvertMaxStatToLocalTime(TimestampValue* v) const; > As these are not modified, different timezone db will be used during per-ro I think one problem is that the JVM method I'm mimicking here doesn't handle those repeated times correctly, so I'm having trouble reasoning what the correct boundaries would be. I could hard-code adding/subtracting 1hr all the time when using this legacy mode, which seems better than disabling it completely. -- To view, visit http://gerrit.cloudera.org:8080/22293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1271ed1da0b74366ab8315e7ec2d4ee47111e067 Gerrit-Change-Number: 22293 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 15 Jan 2025 23:31:00 +0000 Gerrit-HasComments: Yes
