Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22293 )
Change subject: IMPALA-13627: Handle legacy Hive timezone conversion ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/22293/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22293/3//COMMIT_MSG@37 PS3, Line 37: impact on performance > Did you make some benchmarks? It could be useful to have an estimate of the Ack http://gerrit.cloudera.org:8080/#/c/22293/3/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/22293/3/be/src/service/impala-server.cc@362 PS3, Line 362: use_legacy_hive_timestamp_conversion > I don't think that a new flag is really needed as you can override the quer Reminds me I need to add documentation for the new query option. http://gerrit.cloudera.org:8080/#/c/22293/3/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/22293/3/common/thrift/Frontend.thrift@1081 PS3, Line 1081: i64 > nit: why int64? Calendar.get() return int I think I was looking at what Boost would accept, not what Calendar could generate. -- To view, visit http://gerrit.cloudera.org:8080/22293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1271ed1da0b74366ab8315e7ec2d4ee47111e067 Gerrit-Change-Number: 22293 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 15 Jan 2025 23:23:43 +0000 Gerrit-HasComments: Yes
