Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22301 )
Change subject: IMPALA-13642: Fix unused test vector in test_scanners.py ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/22301/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22301/1//COMMIT_MSG@11 PS1, Line 11: exec_option nor debug_action. > I'm not clear why mutating the vector is a problem. As far as I can tell py vector.get_value('exec_option') is a map, and vector generator does not deepcopy this map. If not deepcopying in test method, then we should deepcopy it in vector generator. ps2 add this deepcopying. http://gerrit.cloudera.org:8080/#/c/22301/1//COMMIT_MSG@24 PS1, Line 24: impala-python3-common.sh. Adds flake8==3.9.2 in py3-requirements.txt, > typo: dependencies Done http://gerrit.cloudera.org:8080/#/c/22301/1/infra/python/deps/py3-requirements.txt File infra/python/deps/py3-requirements.txt: http://gerrit.cloudera.org:8080/#/c/22301/1/infra/python/deps/py3-requirements.txt@34 PS1, Line 34: # Below are needed only for dev > nit: "Below" Done http://gerrit.cloudera.org:8080/#/c/22301/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/22301/1/tests/query_test/test_scanners.py@472 PS1, Line 472: for i in range(1, 11): > Would this happen automatically thanks to the vector constraint? Not sure i On second thought, 'stored as textfile' here is not needed because TestHdfsScannerSkew is contrained to 'text' format andd tpch.lineitem itself is stored as textfile. -- To view, visit http://gerrit.cloudera.org:8080/22301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b78736327c71323d10bcd432e162400b7ed1d9d Gerrit-Change-Number: 22301 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 06 Jan 2025 23:49:52 +0000 Gerrit-HasComments: Yes
