Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22301 )
Change subject: IMPALA-13642: Fix unused test vector in test_scanners.py ...................................................................... Patch Set 4: (1 comment) ps4 is a rebase. http://gerrit.cloudera.org:8080/#/c/22301/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22301/1//COMMIT_MSG@11 PS1, Line 11: exec_option nor debug_action. > It's worth a check whether this impacts test time noticeably. I wouldn't ex There is no noticeable slowdown from deepcopying vector during generation. I ran this command and it collect 105411 test items quickly. ./run-tests.py --exploration=exhaustive --collect-only query_test/ -- To view, visit http://gerrit.cloudera.org:8080/22301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b78736327c71323d10bcd432e162400b7ed1d9d Gerrit-Change-Number: 22301 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2025 04:55:48 +0000 Gerrit-HasComments: Yes
