Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22301 )
Change subject: IMPALA-13642: Fix unused test vector in test_scanners.py ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22301/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22301/1//COMMIT_MSG@11 PS1, Line 11: exec_option nor debug_action. > vector.get_value('exec_option') is a map, and vector generator does not dee It's worth a check whether this impacts test time noticeably. I wouldn't expect it to, but also doing additional work to simplify a handful of cases (and prevent future mistakes). http://gerrit.cloudera.org:8080/#/c/22301/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/22301/1/tests/query_test/test_scanners.py@472 PS1, Line 472: for i in range(1, 11): > On second thought, 'stored as textfile' here is not needed because TestHdfs Ack -- To view, visit http://gerrit.cloudera.org:8080/22301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b78736327c71323d10bcd432e162400b7ed1d9d Gerrit-Change-Number: 22301 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2025 00:03:44 +0000 Gerrit-HasComments: Yes
