Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 40: (13 comments) d http://gerrit.cloudera.org:8080/#/c/21728/39/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/21728/39/be/src/rpc/authentication.cc@228 PS39, Line 228: a > Nit: an Done http://gerrit.cloudera.org:8080/#/c/21728/39/be/src/rpc/authentication.cc@240 PS39, Line 240: // Enables retrieving the OAuth JWKS from the specified URL without verifying the > This comment does not make sense. Need to add something like "without veri Done http://gerrit.cloudera.org:8080/#/c/21728/39/be/src/rpc/authentication.cc@257 PS39, Line 257: r."); > Nit: in the OAuth token Done http://gerrit.cloudera.org:8080/#/c/21728/39/be/src/rpc/authentication.cc@259 PS39, Line 259: > This help text copies from JWT, but that help text is unhelpful. Please ch Done http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@231 PS40, Line 231: oauth_validate_signature Should be named "oauth_jwt_validate_signature" http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@236 PS40, Line 236: oauth_file_path Should be named "oauth_jwks_file_path" http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@239 PS40, Line 239: oauth_url Should be named "oauth_jwks_url" http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@242 PS40, Line 242: oauth_verify_server_certificate Should be named "oauth_jwks_verify_server_certificate" http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@249 PS40, Line 249: oauth_ca_certificate Should be named "oauth_jwks_ca_certificate" http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@252 PS40, Line 252: oauth_update_frequency_s Should be named "oauth_jwks_update_frequency_s" http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@255 PS40, Line 255: oauth_pulling_timeout_s Should be named "oauth_jwks_pulling_timeout_s" http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@260 PS40, Line 260: oauth_custom_claim_username Should be named "oauth_jwt_custom_claim_username" http://gerrit.cloudera.org:8080/#/c/21728/39/tests/custom_cluster/test_shell_oauth_auth.py File tests/custom_cluster/test_shell_oauth_auth.py: http://gerrit.cloudera.org:8080/#/c/21728/39/tests/custom_cluster/test_shell_oauth_auth.py@30 PS39, Line 30: s > Nit: remove extra space Done -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 40 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:14:04 +0000 Gerrit-HasComments: Yes
