Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21728 )

Change subject: IMPALA-13288: OAuth AuthN Support for Impala
......................................................................


Patch Set 42:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/21728/42/be/src/rpc/authentication.cc
File be/src/rpc/authentication.cc:

http://gerrit.cloudera.org:8080/#/c/21728/42/be/src/rpc/authentication.cc@260
PS42, Line 260: DEFINE_string(oauth_jwt_custom_claim_username, "username", 
"Custom claim of the token that "
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21728/42/be/src/rpc/authentication.cc@1691
PS42, Line 1691:           "OAuth authentication requires 
oauth_jwt_custom_claim_username to be specified.");
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/21728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6
Gerrit-Change-Number: 21728
Gerrit-PatchSet: 42
Gerrit-Owner: gaurav singh <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: gaurav singh <[email protected]>
Gerrit-Comment-Date: Tue, 14 Jan 2025 17:06:05 +0000
Gerrit-HasComments: Yes

Reply via email to