Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 42: (8 comments) http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@231 PS40, Line 231: oauth_jwt_validate_signa > Should be named "oauth_jwt_validate_signature" Done http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@236 PS40, Line 236: oauth_jwks_file > Should be named "oauth_jwks_file_path" Done http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@239 PS40, Line 239: oauth_jwk > Should be named "oauth_jwks_url" Done http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@242 PS40, Line 242: oauth_jwks_verify_server_certif > Should be named "oauth_jwks_verify_server_certificate" Done http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@249 PS40, Line 249: oauth_jwks_ca_certif > Should be named "oauth_jwks_ca_certificate" Done http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@252 PS40, Line 252: oauth_jwks_update_freque > Should be named "oauth_jwks_update_frequency_s" Done http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@255 PS40, Line 255: oauth_jwks_pulling_time > Should be named "oauth_jwks_pulling_timeout_s" Done http://gerrit.cloudera.org:8080/#/c/21728/40/be/src/rpc/authentication.cc@260 PS40, Line 260: oauth_jwt_custom_claim_user > Should be named "oauth_jwt_custom_claim_username" Done -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 42 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Tue, 14 Jan 2025 17:22:26 +0000 Gerrit-HasComments: Yes
