Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22250 )
Change subject: IMPALA-12785: Add commands to control event-processor status ...................................................................... Patch Set 8: (3 comments) Thanks Quanlong! http://gerrit.cloudera.org:8080/#/c/22250/8/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22250/8/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3802 PS8, Line 3802: String err = "EventProcessor is active. Failed to set last synced event id " + What happens if the user pauses EP and then sets it to an already processed event? Will these events be re-processed? Won't it corrupt the table state? http://gerrit.cloudera.org:8080/#/c/22250/8/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@3816 PS8, Line 3816: ep.start(params.getEvent_id()); I think it's still possible at this point that the status is already ACTIVE, isn't it? Is it intentional so that we can skip some events we're not interested in? http://gerrit.cloudera.org:8080/#/c/22250/8/tests/metadata/test_event_processing.py File tests/metadata/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/22250/8/tests/metadata/test_event_processing.py@272 PS8, Line 272: # 5. Test restarting on a future event id Maybe it would be a good idea to put this subcase last so that the skipped events are really the events generated by deleting the unique database. Now cases 6 and 7 don't generate events, but somebody in the future may add new cases without checking this case (number 5). I think if it is the last one, it's less likely to be missed. -- To view, visit http://gerrit.cloudera.org:8080/22250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a19f67264cfe06a1819a22c0c4f0cf174c9b958 Gerrit-Change-Number: 22250 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 22 Jan 2025 13:55:18 +0000 Gerrit-HasComments: Yes
