Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22250 )

Change subject: IMPALA-12785: Add commands to control event-processor status
......................................................................


Patch Set 9: Code-Review+1

(4 comments)

http://gerrit.cloudera.org:8080/#/c/22250/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22250/8//COMMIT_MSG@10
PS8, Line 10: EventProcessor. E.g. to pause the EventProcessor:
            :   impala-shell> :event_processor('pause');
            : to resume the EventProcessor:
            :   impala-shell> :event_processor('start');
> I thought about this approach and the current approach is more compatible.
Ack


http://gerrit.cloudera.org:8080/#/c/22250/8//COMMIT_MSG@20
PS8, Line 20: patch: pause, start,
> Yeah, it's validated in catalogd side, in CatalogServiceCatalog#setEventPro
Ack


http://gerrit.cloudera.org:8080/#/c/22250/8//COMMIT_MSG@34
PS8, Line 34: | EventProcessor status: PAUSED. LastSyncedEventId: 34489. 
LatestEventId: 34489. |
            : +-----------------------------------------
> The restriction comes from the existing codes of MetastoreEventsProcessor#s
Ack


http://gerrit.cloudera.org:8080/#/c/22250/8/common/thrift/CatalogService.thrift
File common/thrift/CatalogService.thrift:

http://gerrit.cloudera.org:8080/#/c/22250/8/common/thrift/CatalogService.thrift@758
PS8, Line 758:  See allowed actions in
> The possible actions are Java enum values of EventProcessorCmdType. Try to
Ack



--
To view, visit http://gerrit.cloudera.org:8080/22250
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a19f67264cfe06a1819a22c0c4f0cf174c9b958
Gerrit-Change-Number: 22250
Gerrit-PatchSet: 9
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Thu, 23 Jan 2025 04:57:05 +0000
Gerrit-HasComments: Yes

Reply via email to