Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22250 )
Change subject: IMPALA-12785: Add commands to control event-processor status ...................................................................... Patch Set 9: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22250/9/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/22250/9/be/src/catalog/catalog-server.cc@459 PS9, Line 459: VLOG_RPC << "SetEventProcessorStatus(): request=" << ThriftDebugString(req); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. http://gerrit.cloudera.org:8080/#/c/22250/9/be/src/catalog/catalog-server.cc@465 PS9, Line 465: VLOG_RPC << "SetEventProcessorStatus(): response=" << ThriftDebugStringNoThrow(resp); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. -- To view, visit http://gerrit.cloudera.org:8080/22250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a19f67264cfe06a1819a22c0c4f0cf174c9b958 Gerrit-Change-Number: 22250 Gerrit-PatchSet: 9 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 23 Jan 2025 03:27:13 +0000 Gerrit-HasComments: Yes
