Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/22378 )
Change subject: IMPALA-13677: Support remote scratch directory cleanup at Impala daemon startup ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22378/4/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/22378/4/be/src/runtime/tmp-file-mgr.cc@474 PS4, Line 474: string dir = tmp_dirs_remote_->path_; : string hostname = ExecEnv::GetInstance()->configured_backend_address().hostname; : string backend_id = PrintId(ExecEnv::GetInstance()->backend_id(), "_"); : string query_id = PrintId(file_group->unique_id(), "_"); : string querylevel_dir = ConstructRemoteDirPath(dir, hostname, backend_id, query_id); All these strings should probably be const? -- To view, visit http://gerrit.cloudera.org:8080/22378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadd49b7384d52bac5ddab4e86cd9f39dc2c88e1b Gerrit-Change-Number: 22378 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 27 Jan 2025 21:41:55 +0000 Gerrit-HasComments: Yes
