Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22378 )
Change subject: IMPALA-13677: Support remote scratch directory cleanup at Impala daemon startup ...................................................................... Patch Set 5: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22378/5/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/22378/5/be/src/runtime/tmp-file-mgr.cc@478 PS5, Line 478: const string querylevel_dir = ConstructRemoteDirPath(dir, hostname, backend_id, query_id); line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadd49b7384d52bac5ddab4e86cd9f39dc2c88e1b Gerrit-Change-Number: 22378 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 28 Jan 2025 11:11:48 +0000 Gerrit-HasComments: Yes
