Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 )
Change subject: IMPALA-13304: Include aggregate instance-level metrics in JSON profile ...................................................................... Patch Set 15: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/21683/15/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/21683/15/be/src/util/runtime-profile-test.cc@2082 PS15, Line 2082: EXPECT_STREQ(events_json[i]["label"].GetString(), NODE_LIFECYCLE_EVENT_LABELS[i].c_str()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21683/15/be/src/util/runtime-profile-test.cc@2146 PS15, Line 2146: if (plan_node_profile["event_sequences"][0].HasMember("unreported_event_instance_idxs")) line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 15 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 28 Jan 2025 09:19:17 +0000 Gerrit-HasComments: Yes
