Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 )
Change subject: IMPALA-13304: Include aggregate instance-level metrics in JSON profile ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/21683/14/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/21683/14/be/src/util/runtime-profile.cc@66 PS14, Line 66: json_profile_event_timestamp_limit, 5, > I have renamed it as `json_profile_event_timestamp_limit`. I think this might be a good query option in the future as it would affect the text and JSON profiles. // A simple timeline + A text profile with simple stats -> 1 (minimal) - buckets all timestamps and gives count, min, max and avg for all events -> 5 (default) - can be set to 20%(default), 25%, 50% or other spans for text profile stats -> 0 (verbose) - provides all timestamps even in experimental profile Please let me know, if I should completely remove the ability to change it or if any other name is preferred. I thought I should to put emphasis on timestamps. So, I have used `json_profile_event_timestamp_limit`. I believe in many cases, it would be useful to have such an option, instead of having completely no control over it at all, either in flags, or as a query option. -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 15 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 28 Jan 2025 09:37:55 +0000 Gerrit-HasComments: Yes
