Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22293 )
Change subject: IMPALA-13627: Handle legacy Hive timezone conversion ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/22293/11/tests/query_test/test_hive_timestamp_conversion.py File tests/query_test/test_hive_timestamp_conversion.py: http://gerrit.cloudera.org:8080/#/c/22293/11/tests/query_test/test_hive_timestamp_conversion.py@32 PS11, Line 32: : @classmethod > This contradicts Csaba's review. Ack http://gerrit.cloudera.org:8080/#/c/22293/11/tests/query_test/test_hive_timestamp_conversion.py@55 PS11, Line 55: > See the commit message for a description of different file metadata scenari Ok, I think you refer to this point. - Hive 3.1.2 (with HIVE-21290) used a new Java API that’s based on tzdata and added metadata to identify the timezone. -- To view, visit http://gerrit.cloudera.org:8080/22293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1271ed1da0b74366ab8315e7ec2d4ee47111e067 Gerrit-Change-Number: 22293 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 11 Feb 2025 23:34:57 +0000 Gerrit-HasComments: Yes
