Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22293 )

Change subject: IMPALA-13627: Handle legacy Hive timezone conversion
......................................................................


Patch Set 13:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22293/11/be/src/benchmarks/convert-timestamp-benchmark.cc
File be/src/benchmarks/convert-timestamp-benchmark.cc:

http://gerrit.cloudera.org:8080/#/c/22293/11/be/src/benchmarks/convert-timestamp-benchmark.cc@115
PS11, Line 115:                   (sec split (old))               30.1       31 
    31.7         1X         1X         1X
              :                         (day split)                526      532 
     534      17.5X      17.2X      16.9X
              :
              : FromUnixTimeNanos:         Function  iters/ms   10%ile   50%ile 
  90%ile     10%ile     50%ile     90%ile
              :                                                                 
         (relative) (relative) (relative)
              : 
---------------------------------------------------------------------------------------------------------
              :                   (sec split (old))               31.2       32 
    32.4         1X         1X         1X
              :                   (sec split (new))               16.3     16.5 
    16.6     0.523X     0.517X     0.513X
              :
              : FromSubsecondUnixTime:     Function  iters/ms   10%ile   50%ile 
  90%ile     10%ile     50%ile     90%ile
              :                                                                 
         (relative) (relative) (relative)
> Thanks for investigating this. Please leave a sort comment (maybe mention I
Done



--
To view, visit http://gerrit.cloudera.org:8080/22293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1271ed1da0b74366ab8315e7ec2d4ee47111e067
Gerrit-Change-Number: 22293
Gerrit-PatchSet: 13
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Wed, 12 Feb 2025 00:28:09 +0000
Gerrit-HasComments: Yes

Reply via email to