Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22293 )
Change subject: IMPALA-13627: Handle legacy Hive timezone conversion ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/22293/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22293/10//COMMIT_MSG@41 PS10, Line 41: : Hive legacy-compatible conversion uses a Java method doing Can you elaborate why HiveLegacyTimezoneConvert need to happen in Java and not in C++? http://gerrit.cloudera.org:8080/#/c/22293/10/be/src/benchmarks/convert-timestamp-benchmark.cc File be/src/benchmarks/convert-timestamp-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/22293/10/be/src/benchmarks/convert-timestamp-benchmark.cc@59 PS10, Line 59: // Benchmark tests for timestamp time-zone conversions : /* : Machine Info: 12th Gen Intel(R) Core(TM) i9-12900K Did you turn off turbo when running this benchmark? sudo cpupower frequency-set --governor performance echo "1" | sudo tee /sys/devices/system/cpu/intel_pstate/no_turbo http://gerrit.cloudera.org:8080/#/c/22293/10/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/22293/10/common/thrift/Frontend.thrift@1096 PS10, Line 1096: struct TCivilTime { Please add comment what is this and how it is used. Why it stop at second and not millisecond or nanosecond? -- To view, visit http://gerrit.cloudera.org:8080/22293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1271ed1da0b74366ab8315e7ec2d4ee47111e067 Gerrit-Change-Number: 22293 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 06 Feb 2025 00:57:05 +0000 Gerrit-HasComments: Yes
