Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22482 )
Change subject: IMPALA-13751: Fix runtime-profile-test failure since IMPALA-13304 ...................................................................... Patch Set 3: (4 comments) The use of randomization make it difficult to triage if this test becomes flaky again in the future. Selected numbers are not printed to JUnit XML when test failed. Hence, I suggest to fix some numbers here instead of randomizing them. http://gerrit.cloudera.org:8080/#/c/22482/3/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/22482/3/be/src/util/runtime-profile-test.cc@1961 PS3, Line 1961: NUM_PROFILES = uni_dis_instances(gen); Fix to 50. http://gerrit.cloudera.org:8080/#/c/22482/3/be/src/util/runtime-profile-test.cc@1968 PS3, Line 1968: BUCKET_SIZE = uni_dis_granularity(gen); Fix to 5. http://gerrit.cloudera.org:8080/#/c/22482/3/be/src/util/runtime-profile-test.cc@1977 PS3, Line 1977: BUCKET_SIZE = uni_dis_granularity(gen); Fix to 50. http://gerrit.cloudera.org:8080/#/c/22482/3/be/src/util/runtime-profile-test.cc@2001 PS3, Line 2001: int64_t dummy_event_duration = 500 / NUM_PROFILES; Fix to 5. -- To view, visit http://gerrit.cloudera.org:8080/22482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If04744e215cac79f255b3d73c3e91e873c13749a Gerrit-Change-Number: 22482 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 18 Feb 2025 20:11:54 +0000 Gerrit-HasComments: Yes
