Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22482 )
Change subject: IMPALA-13751: Fix runtime-profile-test failure since IMPALA-13304 ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/22482/3/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/22482/3/be/src/util/runtime-profile-test.cc@2019 PS3, Line 2019: if (ber_dis_event_probability(gen)){ Consider changing this to something more deterministic. Such as: if (i % 6 != 0) { With 6 being the length of NODE_LIFECYCLE_EVENT_LABELS. http://gerrit.cloudera.org:8080/#/c/22482/3/be/src/util/runtime-profile-test.cc@2024 PS3, Line 2024: seqs[NUM_PROFILES - 1]->MarkEvent(event); Add comment like this: // Set complete events for the last profile so that .... -- To view, visit http://gerrit.cloudera.org:8080/22482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If04744e215cac79f255b3d73c3e91e873c13749a Gerrit-Change-Number: 22482 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 19 Feb 2025 03:00:36 +0000 Gerrit-HasComments: Yes
