Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22482 )
Change subject: IMPALA-13751: Fix runtime-profile-test failure since IMPALA-13304 ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/22482/3/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/22482/3/be/src/util/runtime-profile-test.cc@2079 PS3, Line 2079: // ], > I have now added the test coverage for expected missing events. This is not addressed yet. http://gerrit.cloudera.org:8080/#/c/22482/3/be/src/util/runtime-profile-test.cc@2102 PS3, Line 2102: // Validate the order of event labels in the event sequence : for (size_t i = 0; i < events_json.Size( Assert that if expect_complete_event is False, test must enter this branch. http://gerrit.cloudera.org:8080/#/c/22482/3/be/src/util/runtime-profile-test.cc@2164 PS3, Line 2164: e(ts_stat_cur_json["avg"]), If expect_complete_event is False, assert that missing_events_instance_count is non 0. http://gerrit.cloudera.org:8080/#/c/22482/5/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/22482/5/be/src/util/runtime-profile-test.cc@1960 PS5, Line 1960: 1, Start with 5 at minimum. http://gerrit.cloudera.org:8080/#/c/22482/5/be/src/util/runtime-profile-test.cc@1965 PS5, Line 1965: if (NUM_PROFILES <= 1) { : BUCKET_SIZE = 1; Eliminate this case. Otherwise, it violates timestamp_aggregation=True. If you do want to test case where NUM_PROFILES = BUCKET_SIZE = 1, please create a new dedicated test or parameter to indicate that just like is_zero_bucket_size. http://gerrit.cloudera.org:8080/#/c/22482/5/be/src/util/runtime-profile-test.cc@2120 PS5, Line 2120: EXPECT_EQ(missing_event_instances_expected.size(), missing_event_instances.size()); If expect_complete_event is False, assert that both number is non zero. -- To view, visit http://gerrit.cloudera.org:8080/22482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If04744e215cac79f255b3d73c3e91e873c13749a Gerrit-Change-Number: 22482 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 19 Feb 2025 15:31:44 +0000 Gerrit-HasComments: Yes
