Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10483 )
Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size ...................................................................... Patch Set 2: (1 comment) Thanks for the review. Please see PS4. http://gerrit.cloudera.org:8080/#/c/10483/2/be/src/exec/hdfs-parquet-table-writer.cc File be/src/exec/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/10483/2/be/src/exec/hdfs-parquet-table-writer.cc@789 PS2, Line 789: stringstream ss; : ss << "Minimum required block size is too large, try reducing the number of columns " : "in the target table."; > why use stringstream if you're not going to construct a string? Done -- To view, visit http://gerrit.cloudera.org:8080/10483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e63420e5a093c0bbc789201771708865b16e138 Gerrit-Change-Number: 10483 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Thu, 24 May 2018 23:44:53 +0000 Gerrit-HasComments: Yes
