Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10483 )
Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10483/4/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: http://gerrit.cloudera.org:8080/#/c/10483/4/be/src/exec/hdfs-table-sink.cc@371 PS4, Line 371: output_partition->partition_descriptor->block_size(); > My intent here is to catch any overflow that does not get caught elsewhere I was talking specifically about the case when the partition descriptor's block size is > 2GB. I'm fine with lines 374-377 as a validation before hdfsOpen(), but wondering what cases the block size on the partition descriptor can be so large and whether we need to just cope with it (since it's out of impala's control). -- To view, visit http://gerrit.cloudera.org:8080/10483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e63420e5a093c0bbc789201771708865b16e138 Gerrit-Change-Number: 10483 Gerrit-PatchSet: 4 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Thu, 31 May 2018 21:07:49 +0000 Gerrit-HasComments: Yes
