Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10483 )
Change subject: IMPALA-7044: Prevent overflow when computing Parquet block size ...................................................................... Patch Set 5: Code-Review+2 (1 comment) I'm okay with this as is, but if you decide to try to simplify the logic around block size I could take another look. http://gerrit.cloudera.org:8080/#/c/10483/5/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: http://gerrit.cloudera.org:8080/#/c/10483/5/be/src/exec/hdfs-table-sink.cc@376 PS5, Line 376: HDFS block size must be smaller than 2GB.") It'd probably be good to include block_size in this error message, and also to indicate whether this came from the partition descriptor for the default_bloc_size logic. Otherwise, I think it'll be a bit of work to determine where the bad block size came from. -- To view, visit http://gerrit.cloudera.org:8080/10483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e63420e5a093c0bbc789201771708865b16e138 Gerrit-Change-Number: 10483 Gerrit-PatchSet: 5 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Thu, 31 May 2018 21:12:37 +0000 Gerrit-HasComments: Yes
