Peter Rozsa has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22423 )

Change subject: IMPALA-13674: Enable MERGE statement for Iceberg tables with 
equality deletes
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22423/4/tests/util/iceberg_metadata_util.py
File tests/util/iceberg_metadata_util.py:

http://gerrit.cloudera.org:8080/#/c/22423/4/tests/util/iceberg_metadata_util.py@115
PS4, Line 115:   # Remove unneccessary parts if the table location differs from
             :   # the default location, for example:
             :   # /test-warehouse/iceberg_test/hadoop_catalog/ice/table 
translates to
             :   # /test-warehouse/table
> I think we should take unique_database into account, i.e. do this transform
Done



--
To view, visit http://gerrit.cloudera.org:8080/22423
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I60e48e2731a59520373dbb75104d75aae39a94c1
Gerrit-Change-Number: 22423
Gerrit-PatchSet: 5
Gerrit-Owner: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 26 Feb 2025 15:34:05 +0000
Gerrit-HasComments: Yes

Reply via email to