Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22423 )
Change subject: IMPALA-13674: Enable MERGE statement for Iceberg tables with equality deletes ...................................................................... Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22423/5/tests/util/iceberg_metadata_util.py File tests/util/iceberg_metadata_util.py: http://gerrit.cloudera.org:8080/#/c/22423/5/tests/util/iceberg_metadata_util.py@119 PS5, Line 119: if unique_database: > nit: we early return at L127 if we don't have a unique_database, i.e. it's Moving this body after L127 needs additional changes to handle the prefix so it might be less legible in the end. -- To view, visit http://gerrit.cloudera.org:8080/22423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60e48e2731a59520373dbb75104d75aae39a94c1 Gerrit-Change-Number: 22423 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 27 Feb 2025 12:19:24 +0000 Gerrit-HasComments: Yes
