Hello Daniel Becker, Zoltan Borok-Nagy, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22423
to look at the new patch set (#7).
Change subject: IMPALA-13674: Enable MERGE statement for Iceberg tables with
equality deletes
......................................................................
IMPALA-13674: Enable MERGE statement for Iceberg tables with equality deletes
This change fixes the delete expression calculation for
IcebergMergeImpl, when an Iceberg table contains equality deletes, the
merge implementation now includes the data sequence number in the result
expressions as the underlying tuple descriptor also includes it
implicitly. Without including this field, the row evaluation fails
because of the mismatching number of evaluators and slot descriptors.
Tests:
- manually validated on an Iceberg table that contains equality delete
- e2e test added
Change-Id: I60e48e2731a59520373dbb75104d75aae39a94c1
---
M be/src/exec/iceberg-merge-node.cc
M be/src/exec/iceberg-merge-node.h
M common/thrift/PlanNodes.thrift
M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java
M fe/src/main/java/org/apache/impala/planner/IcebergMergeNode.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java
A
testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-equality-insert.test
A
testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-equality-update.test
M tests/common/file_utils.py
M tests/query_test/test_iceberg.py
M tests/util/iceberg_metadata_util.py
11 files changed, 125 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/22423/7
--
To view, visit http://gerrit.cloudera.org:8080/22423
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I60e48e2731a59520373dbb75104d75aae39a94c1
Gerrit-Change-Number: 22423
Gerrit-PatchSet: 7
Gerrit-Owner: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
