Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 )
Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout ...................................................................... Patch Set 1: (2 comments) Please add another appropriate reviewer for the changes to the .cc files. It looks fine to me but someone more familiar should look as well. http://gerrit.cloudera.org:8080/#/c/10466/1/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/10466/1/be/src/common/global-flags.cc@162 PS1, Line 162: DEFINE_int32(kudu_rpc_timeout_ms, 0, "Timeout (milliseconds) set for Kudu rpcs. This " : "must be a positive value or it will be ignored and Kudu's default of 10s will be " : "used. There is no way to disable timeouts."); : Is this an option that ought to be hidden away from users/customers? If yes, please make sure that in defining this it's properly hidden. Also, it's not clear to me on how this relates to kudu_operation_timeout_ms. Can you clean up the help text? http://gerrit.cloudera.org:8080/#/c/10466/1/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/10466/1/bin/run-all-tests.sh@84 PS1, Line 84: TEST_START_CLUSTER_ARGS="${TEST_START_CLUSTER_ARGS} --impalad_args=--kudu_rpc_timeout_ms=60000" Since this only happens with Kudu on ASAN, I think we only want to enable this if we are under those conditions. A better place to do this is in start_impalad_instances() in bin/start-impala-cluster.py. You can use tests.common.environ specific_build_type_timeout() to tell you whether you're in ASAN or not and set a timeout appropriately. Do a git grep for specific_build_type_timeout and you'll see plenty of examples. -- To view, visit http://gerrit.cloudera.org:8080/10466 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c4a2d87934cd4eb98509512f7060a596894ed53 Gerrit-Change-Number: 10466 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Comment-Date: Tue, 29 May 2018 20:18:03 +0000 Gerrit-HasComments: Yes
