Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 )
Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/10466/2/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/10466/2/be/src/common/global-flags.cc@163 PS2, Line 163: kudu_rpc Not sure if I am nitpicking here but I wonder if it's less confusing to call it kudu_client_rpc_timeout_ms ? In theory, one can consider data stream sender a client of KRPC but this is different from what we think as a Kudu client. So, does the differentiation make sense ? http://gerrit.cloudera.org:8080/#/c/10466/2/be/src/common/global-flags.cc@164 PS2, Line 164: Kudu rpcs Kudu client's rpcs ? http://gerrit.cloudera.org:8080/#/c/10466/2/be/src/common/global-flags.cc@165 PS2, Line 165: kudu_operation_timeout_ms So, kudu_operation_timeout will kick in first if it's >= kudu_operation_timeout_ms ? -- To view, visit http://gerrit.cloudera.org:8080/10466 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c4a2d87934cd4eb98509512f7060a596894ed53 Gerrit-Change-Number: 10466 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Thu, 31 May 2018 23:27:15 +0000 Gerrit-HasComments: Yes
