Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 )
Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/10466/2/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/10466/2/be/src/common/global-flags.cc@163 PS2, Line 163: kudu_cli > Not sure if I am nitpicking here but I wonder if it's less confusing to cal Yes, makes sense to more clearly differentiate this from krpc. http://gerrit.cloudera.org:8080/#/c/10466/2/be/src/common/global-flags.cc@164 PS2, Line 164: Kudu clie > Kudu client's rpcs ? Done http://gerrit.cloudera.org:8080/#/c/10466/2/be/src/common/global-flags.cc@165 PS2, Line 165: ess than kudu_operation_t > So, kudu_operation_timeout will kick in first if it's >= kudu_operation_tim Yes -- To view, visit http://gerrit.cloudera.org:8080/10466 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c4a2d87934cd4eb98509512f7060a596894ed53 Gerrit-Change-Number: 10466 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Mon, 04 Jun 2018 17:46:07 +0000 Gerrit-HasComments: Yes
