Yida Wu has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/22632


Change subject: IMPALA-13868: Fix ASAN build failed in 
test_ai_generate_text_exprs
......................................................................

IMPALA-13868: Fix ASAN build failed in test_ai_generate_text_exprs

In ParseImpalaOptions(), when the input options cannot be parsed,
the error message is constructed incorrectly by directly using the
StringVal pointer without considering its length. This may result
in reading beyond the allocated memory, leading to unexpected
behavior.

This issue was introduced by IMPALA-13565 and triggered ASAN
errors due to new test cases added in IMPALA-13812
(query_test/test_exprs.py).

Fix by ensure the error message is constructed using both the
pointer and its length.

Tests:
Passed the ASAN build tests.

Change-Id: I9f4656e256bb9b31acc2653c3b910788ddf03f2b
---
M be/src/exprs/ai-functions.cc
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/22632/1
--
To view, visit http://gerrit.cloudera.org:8080/22632
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f4656e256bb9b31acc2653c3b910788ddf03f2b
Gerrit-Change-Number: 22632
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <[email protected]>

Reply via email to