Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/22632 )
Change subject: IMPALA-13868: Fix ASAN build failed in test_ai_generate_text_exprs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22632/1/be/src/exprs/ai-functions.cc File be/src/exprs/ai-functions.cc: http://gerrit.cloudera.org:8080/#/c/22632/1/be/src/exprs/ai-functions.cc@130 PS1, Line 130: string(reinterpret_cast<const char*>(options.ptr), options.len) > I found this code comment about StringVal. StringVal doesn't store a null terminated string that's why both string pointer and length are stored in StringVal. The original code using operator << to append to a stringstream assumed options.ptr to be null terminated cstring so properly converting the StringVal into a cstring or string object is required. -- To view, visit http://gerrit.cloudera.org:8080/22632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f4656e256bb9b31acc2653c3b910788ddf03f2b Gerrit-Change-Number: 22632 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 17 Mar 2025 15:54:44 +0000 Gerrit-HasComments: Yes
