Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22632 )
Change subject: IMPALA-13868: Fix ASAN build failed in test_ai_generate_text_exprs ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/22632/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22632/1//COMMIT_MSG@15 PS1, Line 15: This issue was introduced by IMPALA-13565 > The heap-use-after-free issue happen in expr-test. But which test exactly? Added some commit message. I think IMPALA-13565 had unit tests, but it is hard to trigger the asan error, in IMPALA-13812, the new added tests run in parallel, easy to trigger the asan error. http://gerrit.cloudera.org:8080/#/c/22632/1/be/src/exprs/ai-functions.cc File be/src/exprs/ai-functions.cc: http://gerrit.cloudera.org:8080/#/c/22632/1/be/src/exprs/ai-functions.cc@121 PS1, Line 121: ParseImpalaOptions > nit: I was confused at first when the patch mention Options. I thought it w It is a parameter for Impala that contains options to execute the prompt on a specified AI platform using a specific approach. Since the function is just a static local function and our focus is on the asan fix, we might leave it as is http://gerrit.cloudera.org:8080/#/c/22632/1/be/src/exprs/ai-functions.cc@130 PS1, Line 130: string(reinterpret_cast<const char*>(options.ptr), options.len) > I found this code comment about StringVal. Yeah, did a test, this StringVal here doesn't contain the NULL-terminator, so we need to use the length. As for operator <<, I can follow with a new Jira. -- To view, visit http://gerrit.cloudera.org:8080/22632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f4656e256bb9b31acc2653c3b910788ddf03f2b Gerrit-Change-Number: 22632 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 17 Mar 2025 16:34:03 +0000 Gerrit-HasComments: Yes
