Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 )
Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/10584/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10584/1//COMMIT_MSG@19 PS1, Line 19: will no longer load : following the change will that table be purged or retained in catalogd in some sort of unusable state? http://gerrit.cloudera.org:8080/#/c/10584/1//COMMIT_MSG@23 PS1, Line 23: add a "Testing" section... summarize the tests added and which tests were run beyond the added tests and core tests. http://gerrit.cloudera.org:8080/#/c/10584/1/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/10584/1/be/src/util/backend-gflag-util.cc@72 PS1, Line 72: nit: get rid of the ws. run clang on the change as described here: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536 http://gerrit.cloudera.org:8080/#/c/10584/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10584/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@287 PS1, Line 287: public static int MAX_PARTITIONS_PER_TABLE = final? -- To view, visit http://gerrit.cloudera.org:8080/10584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife99a97a891ed14675303ea472abb2932a72cb51 Gerrit-Change-Number: 10584 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 05 Jun 2018 00:00:33 +0000 Gerrit-HasComments: Yes
