Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10584 )

Change subject: IMPALA-7077. Add a configuration for the max number of 
partitions to load
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10584/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/10584/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2067
PS1, Line 2067:     if (curPartitionCount + allHmsPartitionsToAdd.size() > 
HdfsTable.MAX_PARTITIONS_PER_TABLE) {
> these are < 100 chars which is the line limit that gerrit is showing. Do yo
its not explicitly stated for java in the style guide, but given the limits for 
python/c++, it should be 90.



--
To view, visit http://gerrit.cloudera.org:8080/10584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife99a97a891ed14675303ea472abb2932a72cb51
Gerrit-Change-Number: 10584
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jun 2018 18:04:49 +0000
Gerrit-HasComments: Yes

Reply via email to