Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 )
Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10584/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/10584/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2067 PS1, Line 2067: if (curPartitionCount + allHmsPartitionsToAdd.size() > HdfsTable.MAX_PARTITIONS_PER_TABLE) { > Yea, we use 90 chars for Java too. Gerrit defaults to 100. You can re-configure Gerrit for 90 in some config option if that's your thing. http://gerrit.cloudera.org:8080/#/c/10584/1/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogTest.java: http://gerrit.cloudera.org:8080/#/c/10584/1/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@523 PS1, Line 523: public void testPartitionLimit() throws CatalogException { You added the exception handling in "updatePartitionsFromHms()" and in some alter table path (i.e., two places), but there seems to be only one code path tested here. Should we test the other one too here, or is it enough that we test it in the QueryTest? -- To view, visit http://gerrit.cloudera.org:8080/10584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife99a97a891ed14675303ea472abb2932a72cb51 Gerrit-Change-Number: 10584 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 05 Jun 2018 22:06:36 +0000 Gerrit-HasComments: Yes
