Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22930 )

Change subject: WIP: IMPALA-6406: Add CatalogActionLocker for fine grained DDL 
locking
......................................................................


Patch Set 2:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22930/2/fe/src/test/java/org/apache/impala/catalog/CatalogActionLockerTest.java
File fe/src/test/java/org/apache/impala/catalog/CatalogActionLockerTest.java:

http://gerrit.cloudera.org:8080/#/c/22930/2/fe/src/test/java/org/apache/impala/catalog/CatalogActionLockerTest.java@230
PS2, Line 230:           "Acquired RENAME_TABLE_BY_EVENT (S on mydb, X on 
mydb.tbl1, S on newdb, X on newdb.tbl2)");
line too long (101 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ed48d92333787f75b64b8bd878834612433f6f8
Gerrit-Change-Number: 22930
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 21 May 2025 05:14:32 +0000
Gerrit-HasComments: Yes

Reply via email to