Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22930 )
Change subject: WIP: IMPALA-6406: Add CatalogActionLocker for fine grained DDL locking ...................................................................... Patch Set 3: (2 comments) I'm interested, but only time for a cursory look so far. http://gerrit.cloudera.org:8080/#/c/22930/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/22930/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1898 PS3, Line 1898: throws DatabaseNotFoundException, MetastoreNotificationNeedsInvalidateException, DatabaseNotFoundException is a child of CatalogException, so could be removed. http://gerrit.cloudera.org:8080/#/c/22930/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2258 PS3, Line 2258: // do nothing, dbAdded failed The exception really has no additional useful context? -- To view, visit http://gerrit.cloudera.org:8080/22930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ed48d92333787f75b64b8bd878834612433f6f8 Gerrit-Change-Number: 22930 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 21 May 2025 16:49:29 +0000 Gerrit-HasComments: Yes
