Yida Wu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22930 )

Change subject: WIP: IMPALA-6406: Add CatalogActionLocker for fine grained DDL 
locking
......................................................................


Patch Set 4:

(2 comments)

Thanks Michael for the review. I think the basic idea here is to use dynamic 
locking per operation, instead of using static sharded locks

http://gerrit.cloudera.org:8080/#/c/22930/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java:

http://gerrit.cloudera.org:8080/#/c/22930/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1898
PS3, Line 1898:         throws CatalogException, 
MetastoreNotificationNeedsInvalidateException {
> DatabaseNotFoundException is a child of CatalogException, so could be remov
Done


http://gerrit.cloudera.org:8080/#/c/22930/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2258
PS3, Line 2258:       }
> The exception really has no additional useful context?
Added a log.



--
To view, visit http://gerrit.cloudera.org:8080/22930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ed48d92333787f75b64b8bd878834612433f6f8
Gerrit-Change-Number: 22930
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Thu, 22 May 2025 22:46:05 +0000
Gerrit-HasComments: Yes

Reply via email to