Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22986 )
Change subject: IMPALA-14083: Connected user and session user mismatch when cookie based authentication is used with SPNEGO ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/22986/3/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/22986/3/be/src/rpc/authentication.cc@672 PS3, Line 672: GetShortUsernameFromKerberosPrincipal Maybe add a logging here for the username and short name here like line 904? Do we need to check if GetShortUsernameFromKerberosPrincipal() returns empty string? http://gerrit.cloudera.org:8080/#/c/22986/3/fe/src/test/java/org/apache/impala/customcluster/SpnegoTokenGenerator.java File fe/src/test/java/org/apache/impala/customcluster/SpnegoTokenGenerator.java: http://gerrit.cloudera.org:8080/#/c/22986/3/fe/src/test/java/org/apache/impala/customcluster/SpnegoTokenGenerator.java@24 PS3, Line 24: import java.util.Base64; not used in the code http://gerrit.cloudera.org:8080/#/c/22986/3/fe/src/test/java/org/apache/impala/customcluster/THttpClientWithHeaders.java File fe/src/test/java/org/apache/impala/customcluster/THttpClientWithHeaders.java: http://gerrit.cloudera.org:8080/#/c/22986/3/fe/src/test/java/org/apache/impala/customcluster/THttpClientWithHeaders.java@77 PS3, Line 77: THttpClientWithHeaders This class seems only used in custom cluster tests, maybe rename it to TestTHttpClientWithHeaders or MockTHttpClientWithHeaders or CustomClusterTHttpClient? -- To view, visit http://gerrit.cloudera.org:8080/22986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7223e449c32484bfd2295f7a9e728b7c02637e9 Gerrit-Change-Number: 22986 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 10 Jun 2025 04:04:27 +0000 Gerrit-HasComments: Yes
