Jason Fehr has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22986 )

Change subject: IMPALA-14083: Connected user and session user mismatch when 
cookie based authentication is used with SPNEGO
......................................................................


Patch Set 5: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22986/4/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java
File fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java:

http://gerrit.cloudera.org:8080/#/c/22986/4/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java@399
PS4, Line 399:     // cookie_value like 
[email protected]&t=549158755&r=1800557187&a=SPNEGO.
> There is also <base64signature>&<cookie_value>. Updated the comment.
Ah, thanks for the explanation.


http://gerrit.cloudera.org:8080/#/c/22986/4/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java@400
PS4, Line 400:     String[] cookieValueFields = 
cookieFields[0].trim().split("&");
> Expanded the comment before L398
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/22986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7223e449c32484bfd2295f7a9e728b7c02637e9
Gerrit-Change-Number: 22986
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Wed, 11 Jun 2025 17:52:54 +0000
Gerrit-HasComments: Yes

Reply via email to