Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22986 )
Change subject: IMPALA-14083: Connected user and session user mismatch when cookie based authentication is used with SPNEGO ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/22986/3/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java File fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java: http://gerrit.cloudera.org:8080/#/c/22986/3/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java@249 PS3, Line 249: assertNotNull(authMech); > Done Done http://gerrit.cloudera.org:8080/#/c/22986/3/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java@401 PS3, Line 401: String[] authMech = cookieValueFields[4].trim().split("="); > Done Done http://gerrit.cloudera.org:8080/#/c/22986/4/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java File fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java: http://gerrit.cloudera.org:8080/#/c/22986/4/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java@399 PS4, Line 399: assertEquals(5, cookieValueFields.length); I'm not understanding why the cookieValueFields length is expected to be 5. The cookie is generated with 4 key-value pairs each separated by the & character -- https://gerrit.cloudera.org/c/22986/4/be/src/rpc/authentication-util.cc#160 http://gerrit.cloudera.org:8080/#/c/22986/4/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java@400 PS4, Line 400: // Expect cookie_value [email protected]&t=549158755&r=1800557187&a=SPNEGO. Nit: this comment would make more sense if it was above line 398. -- To view, visit http://gerrit.cloudera.org:8080/22986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7223e449c32484bfd2295f7a9e728b7c02637e9 Gerrit-Change-Number: 22986 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 11 Jun 2025 14:46:49 +0000 Gerrit-HasComments: Yes
