Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22986 )
Change subject: IMPALA-14083: Connected user and session user mismatch when cookie based authentication is used with SPNEGO ...................................................................... Patch Set 5: Code-Review+2 (2 comments) Upgrading to +2 after reading through the tests. Also left a few nit comments. http://gerrit.cloudera.org:8080/#/c/22986/5/fe/src/test/java/org/apache/impala/customcluster/THttpClientWithHeaders.java File fe/src/test/java/org/apache/impala/customcluster/THttpClientWithHeaders.java: http://gerrit.cloudera.org:8080/#/c/22986/5/fe/src/test/java/org/apache/impala/customcluster/THttpClientWithHeaders.java@20 PS5, Line 20: // This code is copied from apache/thrift and modified to return can you add the exact path? http://gerrit.cloudera.org:8080/#/c/22986/5/fe/src/test/java/org/apache/impala/customcluster/THttpClientWithHeaders.java@414 PS5, Line 414: public Map<String, List<String>> getResponseHeaders() { This is the new code, right? Can you mark it with a comment? -- To view, visit http://gerrit.cloudera.org:8080/22986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7223e449c32484bfd2295f7a9e728b7c02637e9 Gerrit-Change-Number: 22986 Gerrit-PatchSet: 5 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 12 Jun 2025 13:37:28 +0000 Gerrit-HasComments: Yes
