Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22956 )
Change subject: IMPALA-14107: Increment table version in fireReloadEvent ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/22956/9/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22956/9/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7227 PS9, Line 7227: > Done I need to check more about this. It seems the version in the response is mainly used for sync_ddl=true. Do we have test coverage for sync_ddl=true? Or test_reload_events_with_transient_partitions already fails using the version of updateThriftTable in response? Sending the old snapshot is fine since in local catalog mode, only the table name is used (enough for invalidating the cache). In the legacy catalog mode, this old snapshot looks the same as the latest one in users' perspective, i.e. table metadata, file metadata are the same. -- To view, visit http://gerrit.cloudera.org:8080/22956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bc91023d46a0b57916202d2b64e2cf07b687b74 Gerrit-Change-Number: 22956 Gerrit-PatchSet: 12 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 12 Jun 2025 14:15:56 +0000 Gerrit-HasComments: Yes
