Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22956 )
Change subject: IMPALA-14107: Increment table version in fireReloadEvent ...................................................................... Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/22956/14/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22956/14/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7237 PS14, Line 7237: } : : if (dbWasAdded.getRef()) { : Db addedDb = catalog_.getDb > nit: might be better to move these down on L7253 to explain setVersion(). Done http://gerrit.cloudera.org:8080/#/c/22956/14/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7345 PS14, Line 7345: } finally { : if (tbl.isWriteLockedByCu > nit: remove this comment? The table lock is acquired in this method, not pr Done -- To view, visit http://gerrit.cloudera.org:8080/22956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bc91023d46a0b57916202d2b64e2cf07b687b74 Gerrit-Change-Number: 22956 Gerrit-PatchSet: 15 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 18 Jun 2025 14:14:28 +0000 Gerrit-HasComments: Yes
