Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22956 )
Change subject: IMPALA-14107: Increment table version in fireReloadEvent ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/22956/9/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22956/9/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7227 PS9, Line 7227: > Existing test_reload_events_with_transient_partitions (legacy catalog mode) I ran the test 780 times in local catalog mode without the change on L7240 (i.e. setVersion to tableVersionAfterFireReloadEvent), they all passed. It seems we don't need to increase the catalog version of the response. Increasing the table version is enough. But I haven't run the test with sync_ddl=true yet. -- To view, visit http://gerrit.cloudera.org:8080/22956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bc91023d46a0b57916202d2b64e2cf07b687b74 Gerrit-Change-Number: 22956 Gerrit-PatchSet: 13 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 18 Jun 2025 00:11:01 +0000 Gerrit-HasComments: Yes
