Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22870 )
Change subject: IMPALA-14061: Calcite Planner: added Calcite rules ...................................................................... Patch Set 7: (6 comments) I'm opening this for review again. I made a small change, addressed the comments, but this should be ready to go. http://gerrit.cloudera.org:8080/#/c/22870/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/22870/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@94 PS5, Line 94: expand > expanded nodes Done http://gerrit.cloudera.org:8080/#/c/22870/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@99 PS5, Line 99: coerce > coerced Done http://gerrit.cloudera.org:8080/#/c/22870/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@104 PS5, Line 104: optimize > optimized Done http://gerrit.cloudera.org:8080/#/c/22870/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@116 PS5, Line 116: optimize > optimized Done http://gerrit.cloudera.org:8080/#/c/22870/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java: http://gerrit.cloudera.org:8080/#/c/22870/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java@119 PS5, Line 119: subQuer > Good point, this is logging the wrong thing Done http://gerrit.cloudera.org:8080/#/c/22870/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java@126 PS5, Line 126: decorre > Good point, this is logging the wrong thing Done -- To view, visit http://gerrit.cloudera.org:8080/22870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6671f7ed298a18965ef0b7a5fc10f4912333a52b Gerrit-Change-Number: 22870 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 16 Jun 2025 16:18:42 +0000 Gerrit-HasComments: Yes
