Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22870 )
Change subject: IMPALA-14061: Calcite Planner: added Calcite rules ...................................................................... Patch Set 8: (1 comment) Please also rebase this patch to pick up IMPALA-14144 (Make pip_download.py more tolerant with PEP 503 simple pages). http://gerrit.cloudera.org:8080/#/c/22870/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/22870/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@387 PS8, Line 387: 100 > That's an interesting idea worth exploring! I think it is OK for now to say that "Calcite planner limit max_cnf_exprs up to 100 for performance reason." and then we can revisit it again once Calcite planner becomes our preference. Note also that max_cnf_exprs equals -1 or 0 means unlimited. https://gerrit.cloudera.org/c/15462/ -- To view, visit http://gerrit.cloudera.org:8080/22870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6671f7ed298a18965ef0b7a5fc10f4912333a52b Gerrit-Change-Number: 22870 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 17 Jun 2025 18:09:08 +0000 Gerrit-HasComments: Yes
