Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22870 )
Change subject: IMPALA-14061: Calcite Planner: added Calcite rules ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/22870/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/22870/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@387 PS8, Line 387: 100 Can you still refer to max_cnf_exprs query option here, but cap it to 100 for Calcite planner? That way, we still have reference and can still lower it through query option. http://gerrit.cloudera.org:8080/#/c/22870/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/22870/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@96 PS8, Line 96: RelNode coercedNodesPlan = nit: Add comment what this step does. http://gerrit.cloudera.org:8080/#/c/22870/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@125 PS8, Line 125: ImpalaPlanRel finalOptimizedPlan = nit: Add comment what this step does. -- To view, visit http://gerrit.cloudera.org:8080/22870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6671f7ed298a18965ef0b7a5fc10f4912333a52b Gerrit-Change-Number: 22870 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 17 Jun 2025 15:48:51 +0000 Gerrit-HasComments: Yes
