Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23098 )
Change subject: IMPALA-13235: Add Reusable GFlag Validators ...................................................................... Patch Set 2: (2 comments) Thanks Jason! http://gerrit.cloudera.org:8080/#/c/23098/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23098/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-13235 Is the Jira number correct? This is "IMPALA-13235: Integrate OTel C++ SDK into Impala Backend", which doesn't seem to be directly related. http://gerrit.cloudera.org:8080/#/c/23098/2/be/src/util/gflag-validator-util-test.cc File be/src/util/gflag-validator-util-test.cc: http://gerrit.cloudera.org:8080/#/c/23098/2/be/src/util/gflag-validator-util-test.cc@29 PS2, Line 29: TEST(GFlagValidatorUtil, TestGeZeroSuccessInt32) { The tests for Int32 and Int64 are almost exactly the same, the function bodies could be extracted into function templates. This is true for each validator function, and both success and fail cases, respectively. -- To view, visit http://gerrit.cloudera.org:8080/23098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I752fd90ddfdad864d5d150a92495562d3d8ba0a2 Gerrit-Change-Number: 23098 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 26 Jun 2025 15:24:56 +0000 Gerrit-HasComments: Yes
